Feat/property search improvements #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bryan Stopp <[email protected]>
Co-authored-by: Bryan Stopp <[email protected]>
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
|
Looks good. Only thing odd I am seeing is the horizontal div/spacer appearing over search results when they are loading. Not a deal-breaker, it just seems out of place. |
|
"Living in" section on communities page has unreadable text |
rrusher
previously approved these changes
Apr 30, 2024
There was a problem hiding this comment.
I appreciate the code coverage on the API. It's also well commented.
While I wouldn't advocate for rewriting innerHTML sections using the dom-helpers before go-live, I do think it would be a great task for the customer to learn how maintain the code by refactoring those sections.
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
aem-code-sync
bot
temporarily deployed
to
feat/property-search-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #147
Fixes: #128
Fixes: #197
Fixes #122
Test URLs: